Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent sprintf errors by escaping % in form title #1486

Closed
wants to merge 2 commits into from
Closed

Prevent sprintf errors by escaping % in form title #1486

wants to merge 2 commits into from

Conversation

krokodok
Copy link

Fixes #1445.

Straightforward escaping of % in $post->post_title with %% prevents the error.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix: Describe a bug fix included in this release.
  • New: Describe a new feature in this release.

Release Checklist

  • This pull request is to the master branch.
  • Release version follows semantic versioning. Does it include breaking changes?
  • Update changelog in readme.txt.
  • Bump version in stream.php.
  • Bump Stable tag in readme.txt.
  • Bump version in classes/class-plugin.php.
  • Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

kasparsd
kasparsd suggested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@kasparsd kasparsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see this comment on the other pull request #1485 (review) -- please let me know if I've misunderstood anything.

@krokodok krokodok mentioned this pull request Jun 17, 2024
Closed
10 tasks
@krokodok
Copy link
Author

@kasparsd Tried to complete the % escaping, analogue to #1485.

@krokodok krokodok requested a review from kasparsd June 24, 2024 17:31
@krokodok krokodok mentioned this pull request Jul 16, 2024
Closed
@krokodok
Copy link
Author

Superseeded by #1508.

@krokodok krokodok closed this Jul 22, 2024
@krokodok krokodok deleted the fix/gf-connector-escape-titles branch July 31, 2024 11:15
@krokodok krokodok restored the fix/gf-connector-escape-titles branch July 31, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasparsd kasparsd Awaiting requested review from kasparsd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gravity Forms - Error Saving form
2 participants
@krokodok @kasparsd